Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcjs buildable version #52

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ghcjs buildable version #52

wants to merge 8 commits into from

Conversation

buckie
Copy link

@buckie buckie commented Oct 22, 2016

Big fan of the library, including the api upgrades from 0.3.5.5. I needed to build this via ghcjs and cpphs or thyme.h was blowing it up (linker errors, couldn't figure out which one). Regardless, this version built fine on OSX for ghcjs at the cost of the lens flag. Overall I dislike having a little custom lens as more and more people start using this lib but I do see the motivation as the build times increase. I think given stack and new-build that one time build hit is no longer so onerous.

@erikd
Copy link
Collaborator

erikd commented Oct 23, 2016

@buckie Your PR doesn't build with ghc 7.6 of ghc 7.8:

src/Data/Thyme/Clock/TAI.hs:85:52:
    Not in scope: ‘mempty’

Versions of GHC earlier than 7.10 did not include Data.Monoid in the standard prelude. Fixing this probably involves adding something like:

#if __GLASGOW_HASKELL__ < 710
import Data.Monoid (mappend)
#endif

@buckie buckie force-pushed the feat/ghcjs-buildable branch from a3b56e3 to 142fbf3 Compare October 23, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buckie @erikd